Skip to content

Fixes favicon #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eugenethreat merged 1 commit into from
Feb 10, 2026
Merged

Fixes favicon #64

eugenethreat merged 1 commit into from
Feb 10, 2026
+2 −1

Conversation

@afolksetapart
Copy link
Contributor

@afolksetapart afolksetapart commented Feb 7, 2026 •
edited
Loading

mkdocs-material defines {% block site_meta %} in base.html, but we override that block here.

{% block site_meta %}
...
      <!-- Favicon -->
      <link rel="icon" href="{{ config.theme.favicon | url }}" />

Adding this line back fixes the favicon 404 and causes it to appear as expected.

@afolksetapart afolksetapart mentioned this pull request Feb 7, 2026
Closed
@eugenethreat
Copy link
Member

eugenethreat commented Feb 10, 2026

Totall makes sense - let's see if this works! Thank you :)

@eugenethreat eugenethreat merged commit 8c6401c into phillycommunitywireless:main Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afolksetapart @eugenethreat